Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): use cartesi as compose project name #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

endersonmaia
Copy link
Contributor

This PT will make the docker compose use cartesi as project name.

This way, instead of having a random string as the prefix for containers we'll have cartesi as prefix.

This will make it easier for us to grab logs or execute commands on a specific container, like:

docker logs -f cartesi-validator-1
docker exec -ti cartesi-validator-1 ls -lha /

Copy link

changeset-bot bot commented May 28, 2024

🦋 Changeset detected

Latest commit: ad65f74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cartesi/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@endersonmaia endersonmaia requested a review from tuler May 28, 2024 10:03
@tuler
Copy link
Member

tuler commented May 28, 2024

The drawback is that if you try to run two projects simultaneously it will fail.
Running two projects may already fail because of ports, but I think we provide a way to change ports.
We need to test the behavior and see if the error is graceful.

@endersonmaia endersonmaia self-assigned this Sep 19, 2024
@endersonmaia endersonmaia force-pushed the feat/cartesi-compose-name branch from ed35df5 to ad65f74 Compare September 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants